Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show confirm message if user can vote in all headings #4587

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

decabeza
Copy link
Collaborator

Objectives

In the Participatory Budgets during the "Selecting projects" phase, an alert appears warning the user of the number of headings in which he can support projects. The problem is that this message appears whenever there is more than 1 heading, although the user can select projects in all headings.

support_alert

This PR changes that the message only appears when the user can select in less headings than the maximum number of headings.

For a group of 4 headings, if the Maximum number of headings in which a user can select projects:

= 4: the message don't appear.
< 4: the message appears.

@javierm javierm self-assigned this Jul 14, 2021
@javierm javierm added this to Reviewing in Consul Democracy via automation Jul 14, 2021
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me; definitely an improvement. Thanks! 🎉

Consul Democracy automation moved this from Reviewing to Testing Jul 14, 2021
@javierm javierm merged commit a3324ca into master Jul 14, 2021
@javierm javierm deleted the max_votable_headings branch July 14, 2021 22:18
Consul Democracy automation moved this from Testing to Release 1.4.0 Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants