Fix flaky hidden budget investments spec #4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing sometimes because the conditions we were checking were the same before and after clicking the "Pending" link. So there was a race condition between the request generated by clicking the "Pending" link and the order to click the "Confirm moderation" link. This sometimes resulted in the "Confirm moderation" link not being correctly clicked.
javierm
force-pushed
the
flaky_hidden_spec
branch
from
1930622
to
8b8b1b7
Compare
taitus
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
The test was failing sometimes because the conditions we were checking were the same before and after clicking the "Pending" link. So there was a race condition between the request generated by clicking the "Pending" link and the order to click the "Confirm moderation" link. This sometimes resulted in the "Confirm moderation" link not being correctly clicked.