Simplify investment form in single heading budgets #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
single-budget-views
branch
from
c59dee0
to
4db6fdc
Compare
javierm
changed the title
javierm
force-pushed
the
single-budget-views
branch
from
4db6fdc
to
50e298e
Compare
javierm
force-pushed
the
single-budget-views
branch
2 times, most recently
from
352c3d5
to
214297f
Compare
Note we're using an extra `<span>` element but we could use a CSS grid layout instead. We're not using it because browser compatibility is only 94.56% at the time of writing.
In the form of creating a new investment was hiding the name of the group if it had only one heading, but could be confusing to users if there are, for example, five different groups of one heading. The solution: - If the budget has one group and one heading, the heading selector is hidden. - If the budget has one group and more than one heading, the group name is hidden. - If the budget has more than one group, the group name appears regardless of the number of headings.
javierm
force-pushed
the
single-budget-views
branch
from
214297f
to
88ad711
Compare
Senen
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Visual changes
Before
After
Investment form for budgets with a single heading
Investment form for budgets with multiple headings
