Fix crash destroying budgets with admins/valuators #4528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
budget_with_administrators
branch
from
8790371
to
2b9ca5a
Compare
javierm
changed the title
javierm
force-pushed
the
budget_with_administrators
branch
from
2b9ca5a
to
3e6e3a9
Compare
javierm
changed the title
javierm
force-pushed
the
budget_with_administrators
branch
2 times, most recently
from
930f8ca
to
e9be60b
Compare
We don't allow deleting a budget with associated investments. However, we allow deleting a budget with associated administrators and valuators. This results in a foreign key violation error: PG::ForeignKeyViolation: ERROR: update or delete on table "budgets" violates foreign key constraint "fk_rails_c847a52b1d" on table "budget_administrators" Using the `dependent: :destroy` option when defining the relationship, we remove the association records when removing the budget. As a bonus, we reduce the number of Rubocop offenses regarding the `Rails/HasManyOrHasOneDependent` rule. Only 72 to go! :)
javierm
force-pushed
the
budget_with_administrators
branch
from
e9be60b
to
a0942f6
Compare
taitus
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
We don't allow deleting a budget with associated investments. However, we allow deleting a budget with associated administrators and valuators. This results in a foreign key violation error:
Objectives