Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order loading custom styles #4515

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Fix order loading custom styles #4515

merged 3 commits into from
Jun 2, 2021

Conversation

javierm
Copy link
Member

@javierm javierm commented May 16, 2021

Objectives

  • Make sure custom styles override our styles
  • Allow organizing custom styles in different stylesheets

@javierm javierm self-assigned this May 16, 2021
@javierm javierm added this to Reviewing in Consul Democracy via automation May 16, 2021
@javierm javierm force-pushed the application_css branch 2 times, most recently from 452dd65 to 2c6b8ed Compare May 16, 2021 13:35
@Senen Senen self-assigned this Jun 2, 2021
This way we don't have to use the `!important` flag to override styles.
We have to load the custom styles last so they actually override what we
do.
So other institutions customizing CONSUL can organize their custom code
as they wish to.

We're also updating the comments in the `custom.scss` file, since it was
referencing files which no longer exist.
Consul Democracy automation moved this from Reviewing to Testing Jun 2, 2021
@javierm javierm merged commit 99361a9 into master Jun 2, 2021
Consul Democracy automation moved this from Testing to Release 1.3.1 Jun 2, 2021
@javierm javierm deleted the application_css branch June 2, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants