Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile dependencies #4462

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Update Dockerfile dependencies #4462

merged 4 commits into from
Apr 15, 2021

Conversation

javierm
Copy link
Member

@javierm javierm commented Apr 5, 2021 •
edited
Loading

References

Objectives

  • Make sure the Dockerfile uses the same Ruby version the application uses
  • Update system packages needed for application building
  • Add a new GitHub Actions workflow to check the docker build runs properly

@javierm javierm self-assigned this Apr 5, 2021
@javierm javierm added this to Reviewing in Consul Democracy via automation Apr 5, 2021
@javierm javierm mentioned this pull request Apr 5, 2021
Closed
@javierm javierm force-pushed the docker_2.6 branch 2 times, most recently from 25977a1 to 9cf3578 Compare April 9, 2021 15:55
@taitus taitus assigned taitus and unassigned taitus Apr 13, 2021
@Senen Senen self-assigned this Apr 13, 2021
@javierm javierm force-pushed the docker_2.6 branch 3 times, most recently from dd1c5e1 to 044f968 Compare April 14, 2021 15:16
@javierm javierm changed the title Use Ruby 2.6 in the Dockerfile Update Dockerfile dependencies Apr 14, 2021
@javierm javierm moved this from Reviewing to Testing in Consul Democracy Apr 14, 2021
javierm and others added 3 commits April 15, 2021 12:53
@javierm
Use Ruby 2.6 in the Dockerfile
baa5833 
So we use the same version defined in our .ruby-version file. Besides,
some of the gems we use are not compatible with Ruby 2.4.
@Senen @javierm
Setup a workflow to check Dockerfile build
079fd82 
Based on https://docs.docker.com/ci-cd/github-actions/
@Senen @javierm
Install system packages required to install the pronto gem
d95a3c4
@javierm javierm merged commit c0c2620 into master Apr 15, 2021
Consul Democracy automation moved this from Testing to Release 1.3.0 Apr 15, 2021
@javierm javierm deleted the docker_2.6 branch April 15, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Senen Senen Senen approved these changes

Assignees

@Senen Senen

@javierm javierm

Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Dockerfile to Ruby 2.6.6 Dockerfile: ruby version is incompatible
3 participants
@javierm @Senen @taitus