Bump invisible_captcha from 1.1.0 to 2.0.0 #4410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
force-pushed
the
dependabot/bundler/invisible_captcha-2.0.0
branch
from
446b899
to
d584186
Compare
dependabot
bot
force-pushed
the
dependabot/bundler/invisible_captcha-2.0.0
branch
4 times, most recently
from
a04190c
to
f78dc20
Compare
|
@dependabot rebase |
Bumps [invisible_captcha](https://github.com/markets/invisible_captcha) from 1.1.0 to 2.0.0. - [Release notes](https://github.com/markets/invisible_captcha/releases) - [Changelog](https://github.com/markets/invisible_captcha/blob/master/CHANGELOG.md) - [Commits](markets/invisible_captcha@v1.1.0...v2.0.0) Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/bundler/invisible_captcha-2.0.0
branch
from
f78dc20
to
5fc927b
Compare
The spinner was added in version 2.0.0, so by disabling it we're keeping the behavior we've got in existing CONSUL installations. The problem with the spinner is installations need to add a secret token and share it across instances (when they've got more than one), and if they don't, invisible captcha might report false positives. I guess we could use `Rails.application.secrets.secret_key_base` as secret token, but since we haven't tested this feature at all, it's better to disable it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps invisible_captcha from 1.1.0 to 2.0.0.
Changelog
Sourced from invisible_captcha's changelog.
Commits
7921968prepare v2 release [ci skip]954312bNew Spinner, IP based, validation check (#89)8824e31Modernize supported versions matrix (#86)edb87b0docs: fix Travis badge -> migrated to travis-ci.com for now, probably GH Acti...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)