Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor participatory budgets in draft mode #4369

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Refactor participatory budgets in draft mode #4369

merged 4 commits into from
Feb 23, 2021

Conversation

javierm
Copy link
Member

@javierm javierm commented Feb 18, 2021 •
edited
Loading

References

@javierm javierm self-assigned this Feb 18, 2021
@javierm javierm added this to Reviewing in Consul Democracy via automation Feb 18, 2021
@javierm javierm force-pushed the draft_budgets branch 2 times, most recently from dc20637 to ac6bdd9 Compare February 19, 2021 00:00
@taitus taitus self-assigned this Feb 19, 2021
@javierm javierm force-pushed the draft_budgets branch 4 times, most recently from 9b0e960 to f79c52c Compare February 19, 2021 14:15
Consul Democracy automation moved this from Reviewing to Testing Feb 19, 2021
@javierm javierm changed the base branch from master to admin_budget_form February 19, 2021 19:53
@javierm javierm moved this from Testing to Reviewing in Consul Democracy Feb 19, 2021
Consul Democracy automation moved this from Reviewing to Testing Feb 23, 2021
Base automatically changed from admin_budget_form to master February 23, 2021 15:24
microweb10 and others added 3 commits February 23, 2021 17:05
@microweb10 @javierm
Refactor participatory budgets in draft mode
28caabe 
Previously the draft mode was a phase of the PB, but that had some
limitations.

Now the phase drafting disappears and therefore the PB can have the
status published or not published (in draft mode).

That will give more flexibility in order to navigate through the
different phases and see how it looks for administrators before
publishing the PB and everybody can see.

By default, the PB is always created in draft mode, so it gives you
the flexibility to adjust and modify anything before publishing it.
@microweb10 @javierm
Add task to set published on existing budgets
77aaa5e 
Note we're making the validation rule dynamic so it's affected by the
way we stub the constant in the tests to emulate data created in old
applications.

Co-Authored-By: Javi Martín <[email protected]>
@decabeza @javierm
Add link to preview budget on budgets table
7eda4be
@javierm javierm merged commit 9debf80 into master Feb 23, 2021
Consul Democracy automation moved this from Testing to Release 1.3.0 Feb 23, 2021
@javierm javierm deleted the draft_budgets branch February 23, 2021 17:34
taitus added a commit that referenced this pull request Mar 17, 2021
@taitus
Allow display of budgets created in dev seeds
2b505c4 
Since this PR (Refactor participatory budgets in draft mode #4369) budgets
have a new field "published" to manage whether they  are displayed or not. We
update this field in dev_seeds to be able to display budgets on the public page
budgets.
@taitus taitus mentioned this pull request Mar 17, 2021
Merged
taitus added a commit that referenced this pull request Mar 17, 2021
@taitus
Allow display the budgets created in dev seeds
485d3f8 
Since this PR (Refactor participatory budgets in draft mode #4369) budgets
have a new field "published" to manage whether they  are displayed or not. We
update this field in dev_seeds to be able to display budgets on the public page
budgets.
taitus referenced this pull request Apr 15, 2021
@taitus
Update DEMO seeds
4fa50f3 
Allow display the budgets created in demo seeds

Since this PR (Refactor participatory budgets in draft mode consul#4369) budgets
have a new field "published" to manage whether they  are displayed or not. We
update this field in demo_seeds to be able to display budgets on the public page
budgets.
@javierm javierm mentioned this pull request Apr 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taitus taitus taitus approved these changes

Assignees

@taitus taitus

@javierm javierm

Labels
Budgets Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@javierm @taitus @microweb10 @decabeza