Fix new notifications count #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
notifications_link
branch
from
1aa81a9
to
9554181
Compare
Other than simplifying the view, we can write tests using `click_link`, which makes the tests more robust. Clicking the `.icon-notification` element was causing some tests to fail when defining a window height of 750 pixels in the `admin_budgets` branch.
javierm
force-pushed
the
notifications_link
branch
from
9554181
to
1a4ca41
Compare
It was hard to know where the numbers were coming from; they depended on the padding of the link and the size of the notification icon size. So we're using variables to make it more explicit. However, the code is now too complex, so we'll probably have to simplify it in the future.
We were displaying the total number of notifications with a message "You have N unread notifications", but were using the total number of notifications instead of the unread ones.
We couldn't do this refactoring earlier because we weren't using the unread notifications count. This was fixed in the previous commit.
javierm
force-pushed
the
notifications_link
branch
from
1a4ca41
to
e266e0e
Compare
taitus
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Notes
One test in "Debate behaves like notifiable in-app" failed in the
admin_budgetsbranch when rezising the tests browser window size to 1200x750 due to a<span>being clicked right on the edge of the window. Clicking the link instead seems to solve the problem.