Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add local targets to related list selector #4327

Merged
merged 4 commits into from
Jan 26, 2021
Merged

Add local targets to related list selector #4327

merged 4 commits into from
Jan 26, 2021

Commits on Jan 26, 2021

  1. Add method to easily access a local target by code 

    Similar to what we do in goals and targets.
    @javierm @taitus
    javierm authored and taitus committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    cb57a46 View commit details
    Browse the repository at this point in the history

  2. Add relation between Goal and LocalTarget 

    This is similar to what we do with investments, which belong to a heading
but also belong to a budget. In our case, the reason is we've been asked
to add local targets which belong to a goal but are not related to any
existing target.
Even though we're not implementing that case right now, we're adding the
relation so we don't have to add data migrations in the future.
    @taitus
    taitus committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    0a3de68 View commit details
    Browse the repository at this point in the history

  3. Allow add local targets to RelatedListSelectorComponent

    @taitus
    taitus committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    41ead2b View commit details
    Browse the repository at this point in the history

  4. Rename sdg_related_list to related_sdg_list 

    To maintain consistency with the current names in the database with fields:
:related_sdg_type and :related_sdg_id
    @taitus
    taitus committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    7fa594e View commit details
    Browse the repository at this point in the history