Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDG filters to advanced search #4300

Merged
merged 7 commits into from
Jan 11, 2021
Merged

Add SDG filters to advanced search #4300

merged 7 commits into from
Jan 11, 2021

Conversation

javierm
Copy link
Member

@javierm javierm commented Dec 28, 2020 •
edited
Loading

Objectives

  • Make it easy to filter proposals, debates and budget investments by SDG

Visual Changes

The advanced search form has a goal filter

@javierm javierm added the SDG United Nations Sustainable Development Goals label Dec 28, 2020
@javierm javierm self-assigned this Dec 28, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation Dec 28, 2020
@javierm javierm moved this from Reviewing to Doing in Consul Democracy Dec 29, 2020
@javierm javierm moved this from Doing to Reviewing in Consul Democracy Jan 4, 2021
@javierm javierm marked this pull request as ready for review January 4, 2021 18:07
@javierm javierm changed the base branch from master to sdg_icons_in_index January 4, 2021 18:16
@javierm javierm moved this from Reviewing to Doing in Consul Democracy Jan 4, 2021
@javierm javierm force-pushed the sdg_icons_in_index branch 7 times, most recently from d001239 to 3d1e82c Compare January 5, 2021 14:29
@javierm javierm moved this from Doing to Reviewing in Consul Democracy Jan 5, 2021
@taitus taitus self-assigned this Jan 8, 2021
@javierm javierm force-pushed the sdg_icons_in_index branch 2 times, most recently from 1d65ec6 to 061d011 Compare January 8, 2021 17:12
@javierm javierm force-pushed the sdg_filters branch 2 times, most recently from 624589c to 5101aeb Compare January 8, 2021 17:42
Consul Democracy automation moved this from Reviewing to Testing Jan 9, 2021
@javierm javierm force-pushed the sdg_icons_in_index branch 3 times, most recently from 8b2745c to 6e82077 Compare January 9, 2021 15:16
@javierm
Remove unnecessary advanced search path parameter
dda79a9 
We can use the current path as URL instead of passing it every time.
Passing the `page: 1` parameter is also redundant since by default the
index goes to the first page and the search form does not send any page
parameter.
@javierm
Extract advanced search into a component
2faf99c
@javierm
Simplify accessing advanced search params
f024a64
@javierm
Removed unused CSS rule
a750c48 
There are no elements matching the selector; the element has only one
child (the <form> element) and it doesn't use the `column` class.
@javierm
Simplify advanced search layout width rules
0595f91 
This way, adding a new element is going to be easier.
@javierm
Fix goal order in goal select
8024c4b
@javierm
Add goal filter to advanced search
75fc431
Base automatically changed from sdg_icons_in_index to master January 11, 2021 12:07
@javierm javierm merged commit 36037bb into master Jan 11, 2021
Consul Democracy automation moved this from Testing to Release 1.3.0 Jan 11, 2021
@javierm javierm deleted the sdg_filters branch January 11, 2021 12:11
@javierm javierm mentioned this pull request Jan 21, 2021
Merged
@javierm javierm mentioned this pull request Jun 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taitus taitus taitus approved these changes

Assignees

@taitus taitus

@javierm javierm

Labels
SDG United Nations Sustainable Development Goals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javierm @taitus