Style SDG headers following UN guidelines #4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same way it's done in the official SDG icons. We're also using uppercase with slightly smaller letter spacing for the same reason. Even though we didn't do so in the past, we're moving the font to its own folder inside the vendor folder and including the license file as well in order to make it clear that these files do not follow the same license CONSUL uses.
The same way it's done in UN official SDG pages.
The same it's done in the UN official SDG pages. We could try to split the string on a space which is more or less in the middle. However, this wouldn't work on languages which don't have spaces between works, like Chinese. So in the end I've added a new translation key, where the title is supposed to be split in several lines the same way it's done by the UN.
It didn't fit the screen properly on goals having long words.
taitus
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Visual Changes
On large screens:
On small screens: