Avoid conflict between SDG::Manager classes #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
force-pushed
the
sdg_avoid_mismatch_conflict
branch
from
51221b1
to
8655a33
Compare
On production environments the application wasn't loading because the `SDG::Manager` class was defined in two places. We don't know the exact reasons for the conflict and why these changes fix it.
taitus
force-pushed
the
sdg_avoid_mismatch_conflict
branch
from
8655a33
to
11884b6
Compare
javierm
changed the title
javierm
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Related PR: #4272
Objectives
Avoiding abilities conflict between Manager and SDG::Manager when deploy on production environment.
Notes
We can reproduce this error by running the following command:
rails s -e production