Extend SDG managment section to allow content reviews #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senen
force-pushed
the
sdg_revisions
branch
5 times, most recently
from
984fc71
to
41ca34d
Compare
javierm
reviewed
Dec 24, 2020
javierm
reviewed
Dec 24, 2020
Senen
force-pushed
the
sdg_revisions
branch
6 times, most recently
from
f9a6faa
to
047c5f2
Compare
javierm
reviewed
Jan 11, 2021
app/components/sdg_management/relations/subnavigation_component.html.erb
Outdated
Show resolved
Hide resolved
javierm
reviewed
Jan 15, 2021
and its relation with relatables Note about sdg_review factory: Cannot use the constantize method on the relatable_type as long as the relatable classes will be loaded and this will throw an exception because the database is not available at factiry definition time.
So we can override it when using inheritance.
javierm
reviewed
Jan 18, 2021
So we can use it from components too.
We have three filters: "pending", "all" and "reviewed". Where "pending" is the default one. Now we are rendering the `shared/_filter_subnav` partial we need to stub helper methods defined at the controller and the helper methods that rely on the request parameters to test the component.
Show a notice only once when the user updates the relatable.
Senen
changed the title
This was a false positive in Rubocop, but we can avoid it by using the attribute reader method we've just added.
javierm
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Extends #4269.
Objectives
Extend the SDG content management section to allow users to review user-provided content. Polls and Legislation Processes are marked as reviewed during creation as administrators users always create them.
Only an administrator or an SDG manager user can mark the SDG content as reviewed.
Split index into three sections:
The search form works within the three sections.
When a user with permission updates the relatable, it is marked as reviewed and a notice is shown to the user "Debate updated successfully and marked as reviewed". The users are always redirected to the "Pending" tab to continue reviewing of others relatables.
Visual Changes