-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDG view with related content #4292
Merged
Commits on Dec 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 46e9d2e - Browse repository at this point
Copy the full SHA 46e9d2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for de4be15 - Browse repository at this point
Copy the full SHA de4be15View commit details -
Note we're using the code instead of the ID to get the goal in the URL. IMHO this is what most people would expect; visiting a URL with a "7" takes you to SDG number 7, and not to the one with "7" as a database ID. In order to avoid tests (either automated tests or manual tests) passing by coincidence due to the goal ID and the goal code being the same, I'm shuffling the codes before entering them in the databse. I've tried using `resolve` in the routes so the code is automatically taken into account, but it doesn't work since `resolve` cannot be used inside a namespace, and here we're within the `sdg` namespace.
Configuration menu - View commit details
-
Copy full SHA for 910acff - Browse repository at this point
Copy the full SHA 910acffView commit details -
Configuration menu - View commit details
-
Copy full SHA for a73ab57 - Browse repository at this point
Copy the full SHA a73ab57View commit details
Commits on Dec 27, 2020
-
Use different backgound colors for different goals
The same way it's done by the United Nations.
Configuration menu - View commit details
-
Copy full SHA for 3e7038d - Browse repository at this point
Copy the full SHA 3e7038dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 330efe5 - Browse repository at this point
Copy the full SHA 330efe5View commit details -
Simplify debates and proposals feed layout
Using the `:only-child` selector we can adjust widths with CSS and don't have to rely on methods calculating which features are available.
Configuration menu - View commit details
-
Copy full SHA for 98aea58 - Browse repository at this point
Copy the full SHA 98aea58View commit details -
Use flex layout instead of data-equalizer in feeds
Using data-equalizer is always hard due to the JavaScript it uses, while the flex layout works all the time.
Configuration menu - View commit details
-
Copy full SHA for be9fc22 - Browse repository at this point
Copy the full SHA be9fc22View commit details -
Reuse code between feed components
They were all following the same format. Note we need to group the `see_all` translation keys together (the same way it's done with the `most_active` keys) so we don't have an unused translation warning. We're also moving the "see all" link in processes outside the feed content; the same way it's done in debates and proposals and removing unnecessary classes in the processes feed: the column class is causing the processes not to be aligned with the debates above them, and the margin bottom is not needed because the margin of the footer is already enough.
Configuration menu - View commit details
-
Copy full SHA for fae5227 - Browse repository at this point
Copy the full SHA fae5227View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fcfa7e - Browse repository at this point
Copy the full SHA 2fcfa7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bb0a2d - Browse repository at this point
Copy the full SHA 2bb0a2dView commit details -
Separate the header from the feed content
We were having some style issues when adding the processes feed to the goal view because of this lack of separation. We're using a <section> tag so it's clear where the <header> tag belongs to.
Configuration menu - View commit details
-
Copy full SHA for 06d2933 - Browse repository at this point
Copy the full SHA 06d2933View commit details -
We were jumping from h1 to h3 and some of these sections (cards and processes) had h3 tags inside them. My best guess is we were using h3 so the titles were smaller. So I'm adding a CSS mixin to easily use a font size of a different heading tag.
Configuration menu - View commit details
-
Copy full SHA for 13fbf4e - Browse repository at this point
Copy the full SHA 13fbf4eView commit details -
Note the link to see all processes does not filter by goal because the legislation section does not have any search filters.
Configuration menu - View commit details
-
Copy full SHA for cc9ab70 - Browse repository at this point
Copy the full SHA cc9ab70View commit details -
Display a message when feeds have no items
This is a scenario which will likely take place for at least some of the goals.
Configuration menu - View commit details
-
Copy full SHA for 83400b9 - Browse repository at this point
Copy the full SHA 83400b9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.