Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDG view with related content #4292

Merged
merged 15 commits into from
Dec 28, 2020
Merged

Add SDG view with related content #4292

merged 15 commits into from
Dec 28, 2020

Commits on Dec 23, 2020

  1. Configuration menu
    Copy the full SHA
    46e9d2e View commit details
    Browse the repository at this point in the history
  2. Add empty SDG index

    javierm committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    de4be15 View commit details
    Browse the repository at this point in the history
  3. Add empty SDG goal show page

    Note we're using the code instead of the ID to get the goal in the URL.
    IMHO this is what most people would expect; visiting a URL with a "7"
    takes you to SDG number 7, and not to the one with "7" as a database ID.
    
    In order to avoid tests (either automated tests or manual tests) passing
    by coincidence due to the goal ID and the goal code being the same, I'm
    shuffling the codes before entering them in the databse.
    
    I've tried using `resolve` in the routes so the code is automatically
    taken into account, but it doesn't work since `resolve` cannot be used
    inside a namespace, and here we're within the `sdg` namespace.
    javierm committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    910acff View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a73ab57 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2020

  1. Use different backgound colors for different goals

    The same way it's done by the United Nations.
    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    3e7038d View commit details
    Browse the repository at this point in the history
  2. Extract components for feeds

    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    330efe5 View commit details
    Browse the repository at this point in the history
  3. Simplify debates and proposals feed layout

    Using the `:only-child` selector we can adjust widths with CSS and don't
    have to rely on methods calculating which features are available.
    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    98aea58 View commit details
    Browse the repository at this point in the history
  4. Use flex layout instead of data-equalizer in feeds

    Using data-equalizer is always hard due to the JavaScript it uses, while
    the flex layout works all the time.
    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    be9fc22 View commit details
    Browse the repository at this point in the history
  5. Reuse code between feed components

    They were all following the same format.
    
    Note we need to group the `see_all` translation keys together (the same
    way it's done with the `most_active` keys) so we don't have an unused
    translation warning.
    
    We're also moving the "see all" link in processes outside the feed
    content; the same way it's done in debates and proposals and removing
    unnecessary classes in the processes feed: the column class is causing
    the processes not to be aligned with the debates above them, and the
    margin bottom is not needed because the margin of the footer is already
    enough.
    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    fae5227 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2fcfa7e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2bb0a2d View commit details
    Browse the repository at this point in the history
  8. Separate the header from the feed content

    We were having some style issues when adding the processes feed to the
    goal view because of this lack of separation.
    
    We're using a <section> tag so it's clear where the <header> tag belongs
    to.
    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    06d2933 View commit details
    Browse the repository at this point in the history
  9. Use h2 tags in feed headers

    We were jumping from h1 to h3 and some of these sections (cards and
    processes) had h3 tags inside them.
    
    My best guess is we were using h3 so the titles were smaller. So I'm
    adding a CSS mixin to easily use a font size of a different heading tag.
    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    13fbf4e View commit details
    Browse the repository at this point in the history
  10. Add processes to goal view

    Note the link to see all processes does not filter by goal because the
    legislation section does not have any search filters.
    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    cc9ab70 View commit details
    Browse the repository at this point in the history
  11. Display a message when feeds have no items

    This is a scenario which will likely take place for at least some of the
    goals.
    javierm committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    83400b9 View commit details
    Browse the repository at this point in the history