Bump rubocop-rails from 2.6.0 to 2.9.1 #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
added
the
dependencies
dependabot-preview
bot
force-pushed
the
dependabot/bundler/rubocop-rails-2.9.1
branch
2 times, most recently
from
8502179
to
d1e8fd8
Compare
dependabot-preview
bot
force-pushed
the
dependabot/bundler/rubocop-rails-2.9.1
branch
from
d1e8fd8
to
56abcf2
Compare
|
This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a |
javierm
force-pushed
the
dependabot/bundler/rubocop-rails-2.9.1
branch
from
56abcf2
to
65b254f
Compare
Bumps [rubocop-rails](https://github.com/rubocop-hq/rubocop-rails) from 2.6.0 to 2.9.1. - [Release notes](https://github.com/rubocop-hq/rubocop-rails/releases) - [Changelog](https://github.com/rubocop-hq/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.6.0...v2.9.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
javierm
force-pushed
the
dependabot/bundler/rubocop-rails-2.9.1
branch
3 times, most recently
from
f458b36
to
3865225
Compare
We were already following it most of the time.
We simplify the code a little bit, and make it more consistent since we were already using `where.not` in most places.
We were already following this style in most places.
These issues were detected after upgrading to rubocop-rails >= 2.8.0.
taitus
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-rails from 2.6.0 to 2.9.1.
Release notes
Sourced from rubocop-rails's releases.
Changelog
Sourced from rubocop-rails's changelog.
Commits
addc9d3Cut 2.9.18d10c49Merge pull request #406 from mobilutz/patch-18e4425cRails/WhereEquals add table/column split0728968Merge pull request #407 from koic/make_rails_helper_instance_variable_accept_...4741d6b[Fix #404] MakeRails/HelperInstanceVariableaccept of instance variables97c8578Merge pull request #405 from koic/fix_an_error_for_rails_where_equals3eecd98[Fix #401] Fix an error forRails/WhereEqualsabbb4faMerge pull request #408 from ghiculescu/find-each-bug0ffda34Fix bug inRails/FindEach151b8a6Fix a build errorDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: