Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SDG targets #4260

Merged
merged 4 commits into from
Dec 4, 2020
Merged

Add SDG targets #4260

merged 4 commits into from
Dec 4, 2020

Conversation

Senen
Copy link
Member

@Senen Senen commented Nov 17, 2020 •
edited
Loading

References

Objectives

Add SDG section to list all targets. As the targets are defined by the United Nations there is no need to allow to create, update, or remove targets.

Visual Changes

Captura de pantalla 2020-12-23 a las 14 33 54

@Senen Senen mentioned this pull request Nov 17, 2020
Closed
@Senen Senen added the SDG United Nations Sustainable Development Goals label Nov 17, 2020
@Senen Senen added this to Reviewing in Consul Democracy via automation Nov 17, 2020
javierm
javierm reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments. Let me know what you think 😉.

app/components/admin/sdg/goals/index_component.html.erb Outdated Show resolved Hide resolved
app/components/admin/sdg/targets/index_component.html.erb Outdated Show resolved Hide resolved
app/components/admin/sdg/targets/index_component.html.erb Outdated Show resolved Hide resolved
app/components/admin/sdg/targets/index_component.html.erb Outdated Show resolved Hide resolved
app/controllers/admin/sdg/targets_controller.rb Outdated Show resolved Hide resolved
app/models/sdg/target.rb Outdated Show resolved Hide resolved
@Senen Senen force-pushed the sdg_targets branch 2 times, most recently from a4fdea5 to e5cf71e Compare November 18, 2020 21:17
@Senen Senen moved this from Reviewing to Doing in Consul Democracy Nov 18, 2020
@javierm javierm moved this from Doing to Reviewing in Consul Democracy Nov 19, 2020
javierm
javierm reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. I've left a couple of comments, mainly about the way to sort targets. Let me know what you think, since it's pretty tricky 🤔.

app/models/sdg/target.rb Outdated Show resolved Hide resolved
spec/models/sdg/target_spec.rb Outdated Show resolved Hide resolved
@javierm javierm moved this from Reviewing to Doing in Consul Democracy Nov 19, 2020
@javierm javierm force-pushed the sdg_targets branch 3 times, most recently from 22ee698 to 27d7897 Compare November 20, 2020 21:10
@javierm javierm force-pushed the sdg_targets branch 2 times, most recently from 1e377a1 to 5ef47dd Compare November 23, 2020 17:40
@Senen Senen moved this from Doing to Reviewing in Consul Democracy Nov 25, 2020
@Senen Senen marked this pull request as ready for review November 25, 2020 11:12
Consul Democracy automation moved this from Reviewing to Testing Nov 30, 2020
@javierm javierm moved this from Testing to Doing in Consul Democracy Dec 2, 2020
@javierm javierm force-pushed the sdg_targets branch 2 times, most recently from abab35b to dd8016d Compare December 2, 2020 11:50
Base automatically changed from add-global-sdg-setting to master December 3, 2020 17:50
Senen and others added 4 commits December 4, 2020 15:15
@Senen @javierm
Add SDG target model
c39c721 
and its relation with the SDG goal model.

Add comparable module be able to sort collections of targets
by code attribute.

Co-Authored-By: Javi Martín <[email protected]>
@Senen @javierm
Add SDG targets to seeds
00e91c4 
Co-authored-by: Javi Martín <[email protected]>
@Senen @javierm
Add targets index to the administration
7fb3f19 
Co-authored-by: Javi Martín <[email protected]>
@Senen @javierm
Add subnavigation component to targets and goals
e9d52b5 
Add a new SDG component to make easier to create subnavigation menus.

Co-Authored-By: Javi Martín <[email protected]>
@javierm javierm moved this from Doing to Reviewing in Consul Democracy Dec 4, 2020
Consul Democracy automation moved this from Reviewing to Testing Dec 4, 2020
@javierm javierm merged commit ebcd64a into master Dec 4, 2020
Consul Democracy automation moved this from Testing to Release 1.3.0 Dec 4, 2020
@javierm javierm deleted the sdg_targets branch December 4, 2020 15:40
@javierm javierm self-assigned this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierm javierm javierm approved these changes

Assignees

@Senen Senen

@javierm javierm

Labels
SDG United Nations Sustainable Development Goals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Senen @javierm