Hide related content proposals when these proposals are retired by their authors

[matisnape]

References

#3559

Objectives

Hide retired proposals from "related content" section for show view for: debate, budget investment, proposal

Visual Changes

No changes

Notes

Not applicable

[javierm]

@matisnape Thanks for the pull request. Before reviewing, could you have a look at the failing tests?

[matisnape]

@matisnape Thanks for the pull request. Before reviewing, could you have a look at the failing tests?

@javierm Will do, of course.
However, when I run tests on my local master, I get 47 errors. Do you know what I might be missing in config? It's almost all Capybara errors or stuff like didn't find some text (from screenshots it looks like sleep is required). But there are some like this:

47) Budget Investments Search Advanced search Search by author type Public employee
      Failure/Error: investments = investments.filter(params[:advanced_search]) if params[:advanced_search].present?

      ArgumentError:
        wrong number of arguments (given 1, expected 0)

[javierm]

@matisnape That's strange 🤔. Which Ruby version are you using? What's the content of the .ruby-version file?

[matisnape]

@javierm Yeah, I have 2.5.8 like in the readme. I think last year I had the same issue and just watched the tests touching the area I was working with.
Anyways, I fixed the tests I definitely broke and the build is green :)

[javierm]

That's strange, because the error you mentioned happens when using Ruby 2.6+ but doesn't happen with Ruby 2.5 or below. Anyway, I'll review the changes now that the tests pass.

[javierm]

@matisnape Nice! I completely misunderstood what the issue was about even though I read it several times 😅, but you got it right 👍.

Regarding the tests you mentioned, I think a test in the spec/models/related_content_spec.rb file should do the trick once we've moved the code to the Relationable concern.

[javierm]

Looks good! I'll do some final tests on Monday and merge if everything is OK.

Thanks a lot!