Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in management with successful proposals #4138

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

javierm
Copy link
Member

@javierm javierm commented Sep 22, 2020

References

Background

The page was crashing because it was looking for the supports partial under management/proposals, when the right path was proposals/.

Objectives

Fix a bug causing the page to crash when accessing a successful proposal from the management section.

The page was crashing because it was looking for the `supports` partial
under `management/proposals`, when the right path was `proposals/`.
@javierm javierm added this to Reviewing in Consul Democracy via automation Sep 22, 2020
@javierm javierm self-assigned this Sep 22, 2020
@taitus taitus self-requested a review September 23, 2020 08:52
@taitus taitus self-assigned this Sep 23, 2020
Consul Democracy automation moved this from Reviewing to Testing Sep 23, 2020
@javierm javierm merged commit 0b464f7 into master Sep 23, 2020
Consul Democracy automation moved this from Testing to Release 1.2.0 Sep 23, 2020
@javierm javierm deleted the manage_successful_proposal branch September 23, 2020 09:24
@javierm javierm removed the 1.2 label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants