Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update columns type of attachment file #4115

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Update columns type of attachment file #4115

merged 2 commits into from
Sep 8, 2020

Conversation

taitus
Copy link
Member

@taitus taitus commented Aug 31, 2020

References

Related PR: Bump paperclip from 5.2.1 to 6.1.0 #3905

Objectives

  • Update old migrations to maintain consistency
  • Add migration to change columns type of attachments from integer to bigint

Notes

After merge "Bump paperclip from 5.2.1 to 6.1.0 #3905" as indicated in the release_notes columns type for attachments are changed from integer to bigint.

STABILITY: Change database column type of attachment file size from unsigned 4-byte integer to unsigned 8-byte bigint. The former type limits attachment size to just over 2GB, which can easily be exceeded by a large video file (Laurent Arnoud, Alen Zamanyan).

@taitus taitus self-assigned this Aug 31, 2020
@taitus taitus marked this pull request as draft August 31, 2020 11:08
@javierm javierm added this to Reviewing in Consul Democracy via automation Sep 7, 2020
@javierm javierm moved this from Reviewing to Doing in Consul Democracy Sep 7, 2020
After merge "Bump paperclip from 5.2.1 to 6.1.0 #3905" as indicated in
the release_notes columns type for attachments are changed from integer
to bigint.
For this reason we edit old migrations so that they continue to
generate integer as before.
As suggested in the paperclip update discussed in the previous commit,
we force the type of these fields to be bigint.
@taitus taitus marked this pull request as ready for review September 8, 2020 09:11
@taitus taitus requested a review from javierm September 8, 2020 09:11
@javierm javierm moved this from Doing to Reviewing in Consul Democracy Sep 8, 2020
@javierm javierm self-assigned this Sep 8, 2020
Consul Democracy automation moved this from Reviewing to Testing Sep 8, 2020
@javierm javierm merged commit 1c8b5a0 into master Sep 8, 2020
Consul Democracy automation moved this from Testing to Release 1.2.0 Sep 8, 2020
@javierm javierm deleted the consistency-schema branch September 8, 2020 09:51
@javierm javierm removed the 1.2 label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants