Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get map center longitude from correct place #4114

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

Senen
Copy link
Member

@Senen Senen commented Aug 31, 2020

References

Related Pull Request: #3699

This error was introduced at commit b9ce68b.

Objectives

We were loading map center longitude from wrong map data attribute.

@Senen Senen added the Bug label Aug 31, 2020
@Senen Senen self-assigned this Aug 31, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation Sep 7, 2020
@javierm javierm added the 1.2 label Sep 7, 2020
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 😄. I've left a comment about the test. Let me know what you think 😉.

arguments[:id] = mappable.id

visit send(mappable_show_path, arguments)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the setup for this test is exactly the same as the previous test, and system tests are quite slow, what do you think about merging this test with the previous one? Something like:

scenario "Displays map and marker on #{mappable_factory_name} show page", :js do
  arguments[:id] = mappable.id

  visit send(mappable_show_path, arguments)

  expect(page).to have_css(".map_location")

  within ".map_location" do
    expect(page).to have_css(".map-icon")
  end
end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that mappable show pages only show the map when a marker is defined it has perfect sense to me. Thanks

@javierm javierm moved this from Reviewing to Doing in Consul Democracy Sep 7, 2020
Consul Democracy automation moved this from Reviewing to Testing Sep 15, 2020
@javierm javierm merged commit 2d24347 into consuldemocracy:master Sep 15, 2020
Consul Democracy automation moved this from Testing to Release 1.2.0 Sep 15, 2020
@javierm javierm removed the 1.2 label Sep 17, 2020
@javierm javierm self-assigned this Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants