Bump social-share-button from 1.1.0 to 1.2.3 #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
added
the
dependencies
houndci-bot
reviewed
Aug 24, 2020
| @@ -3,7 +3,7 @@ | |||
| App.SocialShare = { | |||
| initialize: function() { | |||
| $(".social-share-button a").each(function() { | |||
| $(this).append("<span class='show-for-sr'>" + ($(this).data("site")) + "</span>"); | |||
| $(this).append("<span class='show-for-sr'>" + ($(this).data("site").replace(/_app$/, "")) + "</span>"); | |||
There was a problem hiding this comment.
Line 6 exceeds the maximum line length of 110 max-len
javierm
force-pushed
the
dependabot/bundler/social-share-button-1.2.3
branch
3 times, most recently
from
8b1e49d
to
033d751
Compare
javierm
force-pushed
the
dependabot/bundler/social-share-button-1.2.3
branch
from
033d751
to
e235c5e
Compare
javierm
force-pushed
the
dependabot/bundler/social-share-button-1.2.3
branch
from
e235c5e
to
8a40d58
Compare
javierm
force-pushed
the
dependabot/bundler/social-share-button-1.2.3
branch
4 times, most recently
from
89cfe34
to
3352d8b
Compare
javierm
force-pushed
the
dependabot/bundler/social-share-button-1.2.3
branch
from
3352d8b
to
ae079ef
Compare
taitus
approved these changes
Feb 5, 2021
javierm
force-pushed
the
dependabot/bundler/social-share-button-1.2.3
branch
from
ae079ef
to
882c1dc
Compare
taitus
approved these changes
Feb 8, 2021
Bumps [social-share-button](https://github.com/huacnlee/social-share-button) from 1.1.0 to 1.2.3. - [Release notes](https://github.com/huacnlee/social-share-button/releases) - [Changelog](https://github.com/huacnlee/social-share-button/blob/master/CHANGELOG.md) - [Commits](huacnlee/social-share-button@v1.1.0...v1.2.3) Signed-off-by: dependabot-preview[bot] <[email protected]>
These styles were defined twice in our layout stylesheet.
All buttons were using the same styles, so we might as well style them together.
We were using a custom icon because in the past social-share-button didn't have support for whatsapp. But now that it does, we can remove our custom icon. Note we're using the `_app` suffix because that's the name of the icon meant for mobile devices.
The `proposal-show` HTML class was only used in this context to style the whatsapp icon, which is now styled the same way as other social share icons. The `proposal-show` class should be reserved for the actual proposal show action.
The same way we use it for SDG icons.
As far as I can see, the `.jumbo-budget` never had social share button elements inside it.
By using the same selector used by the social-share-button gem, we can remove all the !important rules.
We were only adding styles for facebook and twitter, meaning telegram and whatsapp looked out of place.
javierm
force-pushed
the
dependabot/bundler/social-share-button-1.2.3
branch
from
7928622
to
aed38aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps social-share-button from 1.1.0 to 1.2.3.
Changelog
Sourced from social-share-button's changelog.
Commits
9d0dc29version 1.2.24530b43fix translation_missing on WhatsApp button (#176)0818c67Translate pt-BR (#172)7526d6dversion 1.2.23128e2dMerge pull request #188 from renatamarques97/bugfix/facebook-sharing73c2684bugfix facebook2a4a639version 1.2.130ade1eMerge pull request #187 from CodiTramuntana/fix/whatsapp_urla503e77Fix WhatsApp url8bbb044Main feature, removes jQuery dependency (#173)Visual changes
Before these changes
After these changes