Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid "hint" attribute in forms #4087

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Fix invalid "hint" attribute in forms #4087

merged 2 commits into from
Aug 26, 2020

Conversation

javierm
Copy link
Member

@javierm javierm commented Aug 15, 2020

References

Objectives

  • Remove an invalid HTML attribute we were generating accidentally

@javierm javierm added the Bug label Aug 15, 2020
@javierm javierm self-assigned this Aug 15, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation Aug 15, 2020
@javierm javierm added the 1.2 label Aug 15, 2020
The object is already a method, so we don't need to pass it around.
Using `hint: false` was generating an input with `hint="false"` instead
of generating no hint at all.
@taitus taitus self-assigned this Aug 26, 2020
Consul Democracy automation moved this from Reviewing to Testing Aug 26, 2020
@javierm javierm removed the 1.2 label Aug 26, 2020
@javierm javierm merged commit 946f232 into master Aug 26, 2020
Consul Democracy automation moved this from Testing to Release 1.2.0 Aug 26, 2020
@javierm javierm deleted the fix_hint branch August 26, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants