Disable phase date fields when a phase is disabled #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
disable_phase
branch
9 times, most recently
from
69c957c
to
de76a95
Compare
javierm
force-pushed
the
disable_phase
branch
3 times, most recently
from
1c7400c
to
002088a
Compare
We were using a <label> tag with no associated field where a <legend> tag was more appropriate. With a fieldset, we also make it obvious these fields are related.
The JavaScript involved wasn't working since we removed the disable-date attribute in commit 73ff688. We're also improving the JavaScript in two ways: First, we trigger the `change` event immediately, so when the page loads date fields are disabled when phases are disabled. And second, we don't remove the selected dates when disabling a phase, so disabling it and enabling it again will keep the selected values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
disable-dateattribute in commit 73ff688Objectives
Visual Changes
Before these changes:
After these changes: