Fix poll answer images not being displayed #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
approved these changes
Aug 10, 2020
After updating foundation-rails in commit 58071fd, the orbit slider stopped working properly. That's because the `.orbit-slide` elements now use a `position: absolute` rule, and so our rule for `.orbit-container` elements making their height 100% (which we added in order to be able to add images with different heights) makes them have a height of 0px, since now the `.orbit-slide` elements are not part of the document flow anymore. Making the `.orbit-slide` elements have relative position fixes this issue, but introduces a different one, producing a really bad-looking animation when changing a slide. So we're disabling the animation as well in order to avoid this jump. This change also fixes another issue introduced in commit 58071fd which caused slide controls to stop working when changing slides back and forth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Fix a bug which caused poll question answer images not to be displayed.
Notes
In the past, we used to have an animation effect when switching from one image to a different one. However, we've had to disable it because after the mentioned foundation-rails update with our current styles the animation effect looks really bad 😌.