Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete users when deleting legislation answers #4068

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

microweb10
Copy link
Member

Objectives

When a legislation process is deleted, everything related will be deleted, including the answers. This dependent: :destroy was causing that users accounts were being accidentally deleted.

@microweb10 microweb10 added the Bug label Jul 27, 2020
@microweb10 microweb10 self-assigned this Jul 27, 2020
@microweb10 microweb10 added this to Reviewing in Consul Democracy via automation Jul 27, 2020
@javierm javierm added the 1.2 label Jul 27, 2020
When a legislation process is deleted, everything related will be
deleted, including the answers. This `dependent: :destroy` was causing
that users accounts were being accidentally deleted.
Consul Democracy automation moved this from Reviewing to Testing Jul 27, 2020
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉

What a nasty bug 🤔. I really hope most people are not deleting legislation processes often! 🤞

@javierm javierm merged commit 792ebdb into master Jul 27, 2020
Consul Democracy automation moved this from Testing to Release 1.2.0 Jul 27, 2020
@javierm javierm deleted the bug_delete_users branch July 27, 2020 12:55
@javierm javierm self-assigned this Jul 27, 2020
@javierm javierm removed the 1.2 label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants