Allow links and images on legislation drafts #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
links_and_images_on_legislation
branch
from
12c4a88
to
7db87bf
Compare
Note we're using a new sanitizer. Ideally we'd reuse the `AdminWYSIWYGSanitizer`, but then code that would be correctly shown by markdown-it (like the <h1> tag) wouldn't be shown on the web, which is confusing. Ideally we would configure markdown-it to only allow the tags present in the `AdminWYSIWYGSanitizer` and provide some kind of help showing which tags are allowed.
javierm
force-pushed
the
links_and_images_on_legislation
branch
from
7db87bf
to
151aa60
Compare
taitus
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
Some CONSUL users did have links and/or images on their legislation drafts. They claimed that after upgrading to version 1.1.0 the links and images are gone.
Objectives
Allow links and images on legislation drafts.