Fix deleting searched managers/moderators/admins #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 15, 2020
javierm
force-pushed
the
fix_admin_search
branch
from
d5043e2
to
f3d39cd
Compare
javierm
force-pushed
the
fix_admin_search
branch
from
f3d39cd
to
57de0be
Compare
javierm
force-pushed
the
fix_admin_search
branch
from
57de0be
to
f3f3b5f
Compare
javierm
force-pushed
the
fix_admin_search
branch
from
f3f3b5f
to
5c17591
Compare
We were deleting managers, moderators and administrators based on their user ID, instead of their manager/moderator/administrator ID.
javierm
force-pushed
the
fix_admin_search
branch
from
5c17591
to
acf2a8d
Compare
taitus
approved these changes
Jun 16, 2020
Originally, the code was shared between the index action and the search action, but since commit fb6dbdf that's no longer the case. So in the index action we don't need to check whether a user is a moderator/manager/admin/official or not; they all are.
javierm
force-pushed
the
fix_admin_search
branch
from
acf2a8d
to
99256ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
While displaying search results, we were offering the option to delete managers, moderators and administrators based on their user ID, instead of their manager/moderator/administrator ID.
Objectives