Add ckeditor tabletools plugin #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin provides more control over tables and solves a JS error thrown when user clicks on "Cell properties" ckeditor feature. https://ckeditor.com/cke4/addon/tabletools
Senen
force-pushed
the
ckeditor-table-plugin-addons
branch
from
82c3f61
to
103726f
Compare
Senen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Bug discovered working on #3979.
Objectives
Fix error detected during manual testing of ckeditor table plugin: When a user clicks on table "Cell properties" feature from contextual menu browser throws a javascript error when running in production environment.
Tabletools plugin provides the dialog window to allow users to edit "Cell properties".
Documentation: https://ckeditor.com/cke4/addon/tabletools
How to reproduce
Create a table within any application ckeditor, right click on any cell and the click on "Cell properties" from contextual menu. You will see a javascript error within browser console.
This is happening with all browsers.
Error location:
Visual Changes
None
Notes
This change was successfully tested on production environment!