Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter erased users and show erase reason in admin #3980

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Conversation

decabeza
Copy link
Collaborator

@decabeza decabeza commented Apr 21, 2020

Objectives

When a user removes their account all fields are removed from the database and in admin/users appears a link with the user id without any other information.

This PR adds new filters to show "Active" or "Erased" users showing the erase reason, so the admin can view the reason why the users are removing their accounts.

Visual Changes

Before

before

After

after

@decabeza decabeza force-pushed the erased-users branch 2 times, most recently from f387967 to cf15659 Compare April 21, 2020 12:56
@decabeza decabeza changed the title [WIP] Filter erased users and show erase reason in admin Filter erased users and show erase reason in admin Apr 30, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation May 13, 2020
@javierm javierm self-assigned this Jul 6, 2020
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! 😄. This change makes a lot of sense to me 👍.

I've left a couple of comments. Let me know what you think! 😉

app/controllers/admin/users_controller.rb Outdated Show resolved Hide resolved
app/views/admin/users/_users.html.erb Outdated Show resolved Hide resolved
spec/system/admin/users_spec.rb Show resolved Hide resolved
@javierm javierm moved this from Reviewing to Doing in Consul Democracy Jul 6, 2020
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🙏 😉

Consul Democracy automation moved this from Doing to Testing Jul 17, 2020
@javierm javierm merged commit 7ee3eec into master Jul 17, 2020
Consul Democracy automation moved this from Testing to Release 1.2.0 Jul 17, 2020
@javierm javierm deleted the erased-users branch July 17, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants