Upgrade Ruby to 2.5.8 #3978
Merged
Upgrade Ruby to 2.5.8 #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
ruby2.5
branch
3 times, most recently
from
6fd9570
to
828d203
Compare
javierm
force-pushed
the
ruby2.5
branch
2 times, most recently
from
edc91bc
to
dc53bc9
Compare
javierm
force-pushed
the
ruby2.5
branch
2 times, most recently
from
8bb9f52
to
133cfee
Compare
I'm not sure why the code didn't work without this line, but it doesn't seem to be necessary anymore (maybe after upgrading Ruby or Rails?). I'm removing it now because... why not now? :) The Ruby interpreter is raising a warning due to this line, and in Ruby 2.5 constant lookup has changed slightly (although I don't think this line is affected by that change). Note about the change in the Setting model: Ruby actually ignores return values in setter methods, so the line isn't necessary.
taitus
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives