Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces icons of expand/collapse comments #3972

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Replaces icons of expand/collapse comments #3972

merged 1 commit into from
Apr 17, 2020

Conversation

decabeza
Copy link
Collaborator

References

This PR close #2605.

Objectives

Replaces icons of expand/collapse comments.

Visual Changes

Before

before

After

after

@decabeza decabeza added the UX label Apr 14, 2020
@javierm javierm added this to Reviewing in Consul Democracy via automation Apr 14, 2020
Consul Democracy automation moved this from Reviewing to Doing Apr 16, 2020
javierm
javierm requested changes Apr 16, 2020
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I prefer these icons over the arrows 🤔, but I'm fine with the change 👌.

As usual, I've left a couple of comments 😉.

app/assets/javascripts/comments.js Outdated Show resolved Hide resolved
app/assets/stylesheets/layout.scss Outdated Show resolved Hide resolved
@javierm javierm moved this from Doing to Reviewing in Consul Democracy Apr 17, 2020
Consul Democracy automation moved this from Reviewing to Testing Apr 17, 2020
javierm
javierm approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😄.

@javierm javierm merged commit 87e6ed5 into master Apr 17, 2020
Consul Democracy automation moved this from Testing to Release 1.2.0 Apr 17, 2020
@javierm javierm deleted the icon-comments branch April 17, 2020 17:44
@javierm javierm self-assigned this Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierm javierm javierm approved these changes

Assignees

@javierm javierm

@decabeza decabeza

Labels
UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replaces icons of expand/collapse comments
2 participants
@decabeza @javierm