Add title to differentiate signature sheets #3940
Conversation
andrewcameronsims
force-pushed
the
feature/3557-add_title_to_differentiate_signature_sheets
branch
from
6fc732b
to
6c24f3b
Compare
andrewcameronsims
force-pushed
the
feature/3557-add_title_to_differentiate_signature_sheets
branch
from
6c24f3b
to
77040ac
Compare
javierm
changed the title
There was a problem hiding this comment.
@andrewcameronsims Thank you very much! 🙏 I know how hard it is to continue working on someone else's pull request and update it to the current master branch.
I've just found a couple of small typos. I'll re-test the changes once they're fixed, and will merge the pull request if everything works properly 😄.
| params.require(:signature_sheet).permit( | ||
| :signable_type, | ||
| :signable_id, | ||
| :document_numbers, |
There was a problem hiding this comment.
I guess this line was added due fo a confict on this file 🤔. The field document_numbers no longer exists, so we should remove it.
config/locales/es/activerecord.yml
Outdated
| @@ -302,6 +302,7 @@ es: | |||
| body: "Mensaje" | |||
| title: "Título" | |||
| signature_sheet: | |||
| title: "Titulo" | |||
There was a problem hiding this comment.
There's a small typo here; correct Spanish is "Título" (you can copy the text two lines above this one if your keyboard doesn't generate Spanish characters 😉).
* Internationalisation for admin fields * Correct typos * Additional tests * Replace ternary with if-then statement
andrewcameronsims
force-pushed
the
feature/3557-add_title_to_differentiate_signature_sheets
branch
from
77040ac
to
95c82d8
Compare
|
@javierm Made the requested changes, build is green 😄 |
There was a problem hiding this comment.
@andrewcameronsims Thanks a lot! 🎉. And thanks @cassianoblonski for the original pull request 🙏.
References
Objectives
Add a title to differentiate between signature sheets
Visual Changes