Update Ruby after deploy:updating
#3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to download the most recent CONSUL and check its `.ruby-version` file before installing Ruby. The `rvm1-capistrano` gem knows it and was invoking the `updating` task before installing Ruby. So we were getting a warning in Capistrano about the `updating` task being executed twice.
javierm
force-pushed
the
rvm_updating
branch
from
c83a950
to
6b5d25b
Compare
javierm
changed the title
deploy:updating
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Update Ruby after `deploy:updating`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
.ruby-versionfileBackground
We were invoking the task to install Ruby before updating the application. However, the
rvm1-capistranogem makes sure this task is executed after updating the application, in case it needs to read the Ruby version present in the.ruby-versionfile. So thedeploy:updatingtask was invoked twice, the first time before tasks which were supposed to be executed after it, generating a warning:Objectives
deploy:updatingtask twice, which might lead to bugs during deployment