Apply rubocop Rails/FindBy rule everywhere #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 8, 2019
javierm
changed the title
Rails/FindBy rule everywhere
We didn't detect these cases because by default the rule only searches for offenses in `app/models/`.
javierm
force-pushed
the
find_by_everywhere
branch
from
4c14dea
to
ea2aeab
Compare
We were manually doing a similar thing - only we weren't raising an exception when we should.
houndci-bot
reviewed
Nov 8, 2019
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Apply rubocop Rails/FindBy rule everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
We should probably replace some
find_byusages withfind_by!, but that's an issue for a different pull request.