Fix random title with trailing spaces #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the generated title for a dashboard action ended with a space, the action `click_link(feature.title)` failed because the link shown in the HTML ignores the trailing spaces. Using `strip` solves the problem. Not the most elegant solution, though; ideally we'd generate a better title.
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Fix random title with trailing spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Fix a flaky spec in
spec/features/dashboard/dashboard_spec.rb:282: Proposal's dashboard Request resource with admin requestNotes
When the generated title for a dashboard action ended with a space, the action
click_link(feature.title)failed because the link shown in the HTML ignores the trailing spaces.Using
stripsolves the problem. Not the most elegant solution, though; ideally we'd generate a better title.