Bump ckeditor from 4.2.4 to 4.3.0 #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
added
dependencies
javierm
changed the title
javierm
force-pushed
the
bump_ckeditor
branch
from
008288b
to
73b66be
Compare
This version solves a security issue: https://ckeditor.com/cke4/release/CKEditor-4.11.0 Note this version adds a `ckeditor/samples` folder, which is automatically added to the application's assets manifest even if we remove all CKEditor references in our application. One of the files in that folder makes ExecJS raise a syntax error, causing every page to raise a 500 error.
javierm
force-pushed
the
bump_ckeditor
branch
from
73b66be
to
f240e00
Compare
javierm
changed the title
javierm
changed the title
The new version of CKEditor loads the balloonpanel and balloontoolbar plugins. Even if we don't need them, I haven't found a way to prevent them from loading, meaning we have to precompile them.
javierm
changed the title
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Bump ckeditor from 4.2.4 to 4.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Notes
Compiling the
balloonpanelplugin generates a warning:Unfortutately I haven't found a way to exclude the
balloonpanelplugin (which we don't use) from the build. It isn't a very annoying warning, though, so I guess we'll live with it.