Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HTML areas independent of CKEditor #3802

Merged
merged 4 commits into from
Oct 25, 2019
Merged

Make HTML areas independent of CKEditor #3802

merged 4 commits into from
Oct 25, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 25, 2019

References

Objectives

  • Make it easier to use an inline CKEditor
  • Make it easier to replace CKEditor with another HTML editor

@javierm
Add matcher for CKEditor fields
3012df2
@javierm
Set current locale as HTML language in all layouts
025923a 
The same way it's done in the application layout. Not doing so causes
accessibility issues affecting screen reader users.
@javierm javierm self-assigned this Oct 25, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Oct 25, 2019
@javierm javierm changed the title Reduce coupling between textareas and CKEditor Make HTML areas independent of CKEditor Oct 25, 2019
@javierm
Use text_area instead of cktext_area
6ef07f8 
We're going to change CKEditor to an inline editor, and the "ckeditor"
gem doesn't provide an option to do so.

Since using `cktext_area` would automatically generate a "classic"
iframe CKEditor, we need to use `text_area` and load the editor using
JavaScript. Personally I prefer this option anyway.

Note in the jQuery selector we need to use `textarea.html-area`; using
just `.html-area` would fail if there's an error message associated to
the textarea, since Rails will add the `.html-area` class to the error
message.
@javierm
Remove CKEditor divs
e844b0b 
This way the HTML does not depend on CKEditor, and changing the editor
we use in textareas will require very few changes.
@javierm javierm merged commit 86e1596 into master Oct 25, 2019
Roadmap automation moved this from Reviewing to Release 1.1.0 Oct 25, 2019
@javierm javierm deleted the html_area branch October 25, 2019 15:31
@javierm javierm mentioned this pull request Nov 6, 2019
Merged
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@javierm
Merge pull request consuldemocracy#3802 from consul/html_area
11a5bb9 
Make HTML areas independent of CKEditor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javierm javierm

Labels
Refactoring
Projects
No open projects
Roadmap
  
Release 1.1.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@javierm