Add and apply rubocop rules for empty lines #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
javierm
force-pushed
the
rubocop_empty_lines
branch
from
d30128e
to
fd51268
Compare
We were inconsistent on this one. I consider it particularly useful when a method starts with a `return` statement. In other cases, we probably shouldn't have a guard rule in the middle of a method in any case, but that's a different refactoring.
This comment isn't necessary since Ruby 2.0, where UTF-8 became the default encoding. I've found this issue thanks to the EmptyLineAfterMagicComment rubocop rule.
Unfortunately, there doesn't seem to be a Rubocop rule for this one. I've found these empty lines thanks to Rufo.
We were using it in most places, but not everywhere.
javierm
force-pushed
the
rubocop_empty_lines
branch
from
fd51268
to
d774b8a
Compare
javierm
force-pushed
the
rubocop_empty_lines
branch
from
d774b8a
to
57ef380
Compare
|
This pull request only deals with white space; Travis failures are not related to it. |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Add and apply rubocop rules for empty lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
We were very inconsistent regarding empty lines at the beginning/end of a class/module/block.
Objectives