Bump capybara from 2.17.0 to 3.29.0 #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
added
the
dependencies
|
@dependabot rebase |
dependabot-preview
bot
force-pushed
the
dependabot/bundler/capybara-3.29.0
branch
from
4d5cc9c
to
21506df
Compare
|
It looks like some tests fail due to different behavior in Capybara regarding line breaks in the content 🤔, probably related to teamcapybara/capybara#2001. |
dependabot-preview
bot
force-pushed
the
dependabot/bundler/capybara-3.29.0
branch
from
21506df
to
237bbb5
Compare
|
Sorry, only users with push access can use that command. |
dependabot-preview
bot
force-pushed
the
dependabot/bundler/capybara-3.29.0
branch
from
237bbb5
to
f2635cb
Compare
|
@dependabot rebase |
dependabot-preview
bot
force-pushed
the
dependabot/bundler/capybara-3.29.0
branch
from
f2635cb
to
5068bca
Compare
javierm
force-pushed
the
dependabot/bundler/capybara-3.29.0
branch
from
83a4f34
to
d468185
Compare
|
A newer version of capybara exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
javierm
force-pushed
the
dependabot/bundler/capybara-3.29.0
branch
from
d468185
to
f2bc598
Compare
javierm
force-pushed
the
dependabot/bundler/capybara-3.29.0
branch
from
f2bc598
to
6f58ba8
Compare
javierm
approved these changes
Mar 13, 2020
Bumps [capybara](https://github.com/teamcapybara/capybara) from 2.17.0 to 3.29.0. - [Release notes](https://github.com/teamcapybara/capybara/releases) - [Changelog](https://github.com/teamcapybara/capybara/blob/master/History.md) - [Commits](teamcapybara/capybara@2.17.0...3.29.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
With the rack driver, the `ballot_sheet.data` text was being converted from newline characters to whitespace, while with the JavaScript driver we get newline characters for `<br>` tags, as we expect.
Checking the whole text is tricky because the text has a `<br>` tag, and now Capybara doesn't normalize whitespace by default anymore. Here are a couple more options we could use: ``` expect(page).to have_content strip_tags(message.gsub(/\s*<br>\s*/,"\n")) expect(page).to have_content strip_tags(message), normalize_ws: true ``` But then developers would wonder why we're doing all this, and would need an extra effort to fully understand the test. Since the tests are only checking the presence of the flash message, checking a relevant part of the test is enough, works with any version of Capybara, and makes the test easy to follow.
The following code: ``` <span class="show-for-sr">You're on page</span> 1 ``` Will generate an element with `position: absolute`. When reading the contents, it's not clear whether this element is supposed to be in the same paragraph or in a different one. Currently Capybara treats it as if it were part of a different paragraph. Since this could be the way screen readers read the text, I'm changing the test to reflect this fact. We might change our minds in the future.
javierm
force-pushed
the
dependabot/bundler/capybara-3.29.0
branch
from
6f58ba8
to
fe20688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps capybara from 2.17.0 to 3.29.0.
Changelog
Sourced from capybara's changelog.
Commits
a5c368fUpdate README for 3.29_stable branch64ac389Prepare for 3.29 release6319738Move common file input click emulation behavior into modulefdf0095Update History.md [ci skip]2cf317aSupport rack_test driver toggling details elementsd0ca4bbFix simple node visibility for open details element descendantsad5d347Remove extraneous focus_ metadata32b2261Set download directory to work with headless chrome 77ea6486bEmulate click on file input when attaching file using Selenium with Chrome an...2e05279JRuby 9.2.8.0 has been released and no longer needs the lazy results workaroundDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump nowin your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: