Use relative URLs where possible #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
relative_urls
branch
2 times, most recently
from
2d3677a
to
d399424
Compare
We now use `polymorphic_hierarchy_path` instead.
The main reason to use it was the `rel` attribute for previous/next pages not being indexed correctly by certain search engines when using a relative URL. However, AFAIK that only applied to `<link>` tags, not to `<a>` tags, and only if a `<base>` tag was defined. In any case, it looks like the same search engines don't use the `rel` attribute for previous/next to index pages anymore.
In general, we always use relative URLs (using `_path`), but sometimes we were accidentally using absolute URLs (using `_url`). It's been reported i might cause some isuses if accepting both HTTP and HTTPS connections, although we've never seen the case. In any case, this change makes the code more consistent and makes the generated HTML cleaner.
javierm
force-pushed
the
relative_urls
branch
from
d399424
to
27468b0
Compare
Closed
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Use relative URLs where possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
<a>tags in pagination, which were probably added thinking search engines used them the same way the use<llink>tags (in any case, therel=prev/nexttag doesn't need absolute URLs anymore)