Remove leftover code #3740
Merged
Remove leftover code #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
remove_obsolete_code
branch
from
7ca2433
to
ccf24da
Compare
decabeza
approved these changes
Oct 3, 2019
javierm
force-pushed
the
remove_obsolete_code
branch
from
499b02e
to
f85f7ca
Compare
This method wasn't used since commit 24dde9c.
The rest of the sandbox code was removed in commit d679c1e.
This code doesn't work since commit a5338a4.
It's shorter, it's easier to extend its behaviour, and it's easier to integrate with other parts of our application, like translations.
Links already use GET by default, so there's no need to specify it. Furthermore, using `method: :get` makes a link incompatible with turbolinks.
javierm
force-pushed
the
remove_obsolete_code
branch
from
f85f7ca
to
27522f6
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Remove leftover code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Remove code we accidentally left over while removing the code using it.