Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use let to remove duplication in specs #3728

Merged
merged 7 commits into from
Sep 30, 2019
Merged

Use let to remove duplication in specs #3728

merged 7 commits into from
Sep 30, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Sep 25, 2019

Objectives

  • Simplify data setup in specs
  • Make it easier to remove useless assignments while maintaining the code vertically aligned

@javierm javierm added the Specs label Sep 25, 2019
@javierm javierm self-assigned this Sep 25, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Sep 25, 2019
@javierm javierm force-pushed the simplify_valuator_factories branch 2 times, most recently from 4965814 to c6808c9 Compare September 30, 2019 13:21
@javierm
Extract draft version variable to a let block
297466f 
This way we can reuse the code (in some cases) and we can avoid instance
variables (in some other cases).
@javierm
Remove useless assignments in draft versions specs
2522144 
Now that we've moved the `draft_version` variable with `let`, these
variables can be removed without making it harder to read the code
vertically.
@javierm
Use let in valuator group
e3a2c0c 
This way we can remove a useless assignment without making the code
harder to read vertically.
@javierm
Use let to creat users in voter spec
d5c0e1c 
We remove duplication, and we better isolate useless assignments.
@javierm
Remove let only used once
55c4a95
@javierm
Use let only in the examples using the variables
4ead96b 
These variables were only used in the `validations` block; the rest of
the tests re-defined them, making the code hard to follow.
@javierm
Remove duplication in email specs using let
72c10ab
@javierm javierm changed the base branch from simplify_valuator_factories to master September 30, 2019 13:57
@javierm javierm merged commit a43a313 into master Sep 30, 2019
Roadmap automation moved this from Reviewing to Release 1.1.0 Sep 30, 2019
@javierm javierm deleted the use_let branch September 30, 2019 14:18
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@javierm
Merge pull request consuldemocracy#3728 from consul/use_let
f8c5177 
Use `let` to remove duplication in specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees

@javierm javierm

Labels
Specs
Projects
No open projects
Roadmap
  
Release 1.1.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javierm @houndci-bot