Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests to calculate winners #3726

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Add more tests to calculate winners #3726

merged 2 commits into from
Sep 25, 2019

Conversation

javierm
Copy link
Member

@javierm javierm commented Sep 25, 2019

Objectives

  • Use test descriptions which show the specific case they're testing
  • Add test cases we weren't testing

@javierm javierm added the Specs label Sep 25, 2019
@javierm javierm self-assigned this Sep 25, 2019
@javierm javierm added this to Reviewing in Roadmap via automation Sep 25, 2019
houndci-bot
houndci-bot reviewed Sep 25, 2019
View reviewed changes
spec/models/budget/result_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/result_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/result_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/result_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/result_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/result_spec.rb Outdated Show resolved Hide resolved
spec/models/budget/result_spec.rb Outdated Show resolved Hide resolved
@javierm
Add test for lines order calculating winners
5a934de 
We were creating the investments with more ballot counts first in every
test, so the tests would pass if we ordered the investments by creation
date instead of ordering them by the number of ballot lines.
@javierm javierm changed the title Add more test to calculate winners Add more tests to calculate winners Sep 25, 2019
@javierm
Add a test for an edge case calculating winners
1bb53b1 
We weren't testing what happens if the next investment exceeds the
budget, but the following one doesn't.
@javierm
Copy link
Member Author

javierm commented Sep 25, 2019 •
edited
Loading

Travis failure is not related to this pull request but to issue #3703.

@javierm javierm merged commit edc396a into master Sep 25, 2019
Roadmap automation moved this from Reviewing to Release 1.1.0 Sep 25, 2019
@javierm javierm deleted the test_calculate_winner branch September 25, 2019 14:05
smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020
@javierm
Merge pull request consuldemocracy#3726 from consul/test_calculate_wi…
ef567ba 
…nner

Add more tests to calculate winners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees

@javierm javierm

Labels
Specs
Projects
No open projects
Roadmap
  
Release 1.1.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javierm @houndci-bot