Remove isolated useless assignments #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 25, 2019
javierm
force-pushed
the
simplify_poll_factories
branch
from
65ef29f
to
320b755
Compare
Boolean arguments are harder to read, so we added a useless variable. This is the perfect scenario for a named parameter.
The same way it's done in other places. We also remove a useless assignment.
It doesn't really affect the tests, but it helps isolate useless assignments, and we already did it this way 94% of the time.
These variables are not surrounded by other assignments, and so they can safely be removed without making it harder to read the code vertically.
While there are other variables in these tests, they're not part of the setup of the test, and so these ones can be removed while keeping the code easy to read.
We also remove useless assignments, and use a neutral email address in the sample data.
javierm
force-pushed
the
isolated_unused_variables
branch
from
b66c4ce
to
5fa155c
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…ariables Remove isolated useless assignments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Notes
In this pull request we're only removing the useless assignments which don't affect code legibility at all.