Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused and obsolete code #3718

Merged
merged 9 commits into from
Sep 25, 2019
Merged

Remove unused and obsolete code #3718

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f767f23
Remove obsolete notices in booth assignments
javierm Sep 24, 2019
0603093
Remove obsolete poll answers variable
javierm Sep 24, 2019
748ee3d
Remove obsolete confirm messages references
javierm Sep 24, 2019
fb6d12c
Remove obsolete data creation
javierm Sep 24, 2019
fcaa30d
Remove obsolete URL reference
javierm Sep 24, 2019
cb20698
Remove unnecessary code
javierm Sep 24, 2019
82ea866
Remove commented graphql tests
javierm Sep 23, 2019
da425b9
Remove commented graphql code
javierm Sep 23, 2019
9fcea17
Remove useless parameter in URL
javierm Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Remove useless parameter in URL 
The proposal parameter was accidentally added in commit 16692c9, but
the proposals index doesn't receive a proposal as parameter.
  • Loading branch information
@javierm
javierm committed Sep 24, 2019
commit 9fcea178497fbbe976cc60afac2953e561962985
2 changes: 1 addition & 1 deletion spec/features/proposals_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
proposal_with_image = create(:proposal)
image = create(:image, imageable: proposal_with_image)

visit proposals_path(id: proposal)
visit proposals_path

within("#proposal_#{proposal.id}") do
expect(page).not_to have_css("div.with-image")
Expand Down