Use puma instead of unicorn #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
puma
branch
3 times, most recently
from
c25464f
to
63d792b
Compare
javierm
commented
Oct 10, 2019
Our current unicorn task wasn't working in some cases. We also had a version in the `capistrano` branch, which was the one we recommended. However, that version assumed RVM, a certain ruby version and a certain deploy folder were used. This version uses `bundle exec` and variables like `release_path`, so it does not depend on any specific configuration. Even if we're replacing unicorn with puma, I wanted to make this change in case we need it as a reference in the future.
javierm
force-pushed
the
puma
branch
6 times, most recently
from
d45b60b
to
dafa1f8
Compare
Puma is the server we use in the development environment, so this way we don't need to maintain two servers. Furthermore, puma seems to offer a few advantages over unicorn (like multithreading) and no disadvantages.
Puma was adding commands to `rvm_map_bins`, which meant RMV1 wasn't using the default value of `rvm1_map_bins`. Changing the order we use to require `rmv1/capistrano3` and `capistrano/puma` did not fix the issue.
javierm
force-pushed
the
puma
branch
2 times, most recently
from
90cce77
to
5d97745
Compare
Old CONSUL nginx configurations will probably have a reference to a unicorn socket. Making that file a symbolic link to a puma socket makes it possible for the application to keep working without updating the nginx configuration file.
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Use puma instead of unicorn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
capistrano3-pumaRelease notes
To:
So when reading that file it's obvious you're using puma and not unicorn.