Make WebSection seeds idempotent #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
fix_web_section_seeds
branch
from
8f293ba
to
da39088
Compare
voodoorai2000
approved these changes
Jul 23, 2019
Each time we were loading the seeds file, more web sections were created. On production it meant running `db:seeds` several times created the records even if they already existed. During the test, it meant 5 more records were created before every test, so after ending a test run, thousands of records existed, making banner tests very slow.
javierm
force-pushed
the
fix_web_section_seeds
branch
from
da39088
to
c3bcb10
Compare
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…eeds Make WebSection seeds idempotent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
Creating more records before every test meant after running model tests the table had potentially thousands of records, and tests rendering all of them were slower and sometimes exceeded Capybara's wait time.
I've updated #3621 so after upgrading to Rails 5.1 at least the seeds will only be loaded once when running the tests. Maybe we shouldn't even load the seeds file, and just execute
Setting.reset_defaults🤔, but then we would need to change the tests relying on default custom pages being created.