Migrate CoffeeScript to JavaScript #3653

javierm · 2019-07-02T15:58:15Z

References

Depends on pull requests #3652, #3654 and #3651.

Background

CoffeeScript was a great language which helped avoiding some JavaScript pitfalls. Thanks to it, ECMAScript 6 was born.

However, nowaday there are way more developers who can write or understand JavaScript code than developers who can write or understand CoffeeScript code, particularly since ECMAScript 6 was released back in 2015.

Objectives

Migrate our CoffeeScript code to JavaScript so it's understood by more developers
Add rules so we are notified when we fall into some of the JavaScript pitfalls
Add rules regarding JavaScript coding style

Notes

For now we aren't configuring babel nor any other transpiler, and aren't adding webpack nor any other JavaScript dependencies, so we're using ECMAScript 5 syntax and functionality to keep the same browser compatibility we had before these changes

app/assets/javascripts/answers.js

app/assets/javascripts/votations.js

houndci-bot · 2019-07-02T15:58:39Z

app/assets/javascripts/valuation_budget_investment_form.js

+ }
+ },
+ showFeasibilityFieldsOnChange: function() {
+ $("#valuation_budget_investment_edit_form input[type=radio][name='budget_investment[feasibility]']").change(function() {


Line 27 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T15:58:39Z

app/assets/javascripts/valuation_budget_investment_form.js

+ },
+ showFeasibilityFields: function() {
+ var feasibility;
+ feasibility = $("#valuation_budget_investment_edit_form input[type=radio][name='budget_investment[feasibility]']:checked").val();


Line 19 exceeds the maximum line length of 110 max-len

app/assets/javascripts/tracks.js

houndci-bot · 2019-07-02T15:58:42Z

app/assets/javascripts/legislation_annotatable.js

+ element: this,
+ viewerExtensions: [App.LegislationAnnotatable.viewerExtension],
+ editorExtensions: [App.LegislationAnnotatable.editorExtension]
+ }).include(App.LegislationAnnotatable.scrollToAnchor).include(App.LegislationAnnotatable.addWeightClasses).include(annotator.storage.http, {


Line 218 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T15:58:42Z

app/assets/javascripts/legislation_annotatable.js

+ var current_user_id;
+ $(document).off("renderLegislationAnnotation").on("renderLegislationAnnotation", App.LegislationAnnotatable.renderAnnotationComments);
+ $(document).off("click", "[data-annotation-id]").on("click", "[data-annotation-id]", App.LegislationAnnotatable.onClick);
+ $(document).off("click", "[data-cancel-annotation]").on("click", "[data-cancel-annotation]", function(e) {


Line 195 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T15:58:43Z

app/assets/javascripts/legislation_annotatable.js

+ initialize: function() {
+ var current_user_id;
+ $(document).off("renderLegislationAnnotation").on("renderLegislationAnnotation", App.LegislationAnnotatable.renderAnnotationComments);
+ $(document).off("click", "[data-annotation-id]").on("click", "[data-annotation-id]", App.LegislationAnnotatable.onClick);


Line 194 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T15:58:43Z

app/assets/javascripts/legislation_annotatable.js

+ },
+ initialize: function() {
+ var current_user_id;
+ $(document).off("renderLegislationAnnotation").on("renderLegislationAnnotation", App.LegislationAnnotatable.renderAnnotationComments);


Line 193 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T15:58:43Z

app/assets/javascripts/legislation_annotatable.js

+ $.event.trigger({
+ type: "renderLegislationAnnotation",
+ annotation_id: ann_id,
+ annotation_url: el.closest(".legislation-annotatable").data("legislation-annotatable-base-url"),


Line 152 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T20:58:12Z

app/assets/javascripts/legislation_annotatable.js

+ });
+ } else {
+ $(e.target).find("label").addClass("error");
+ $("<small class='error'>" + data.responseJSON[0] + "</small>").insertAfter($(e.target).find("textarea"));


Line 123 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T20:58:13Z

app/assets/javascripts/legislation_annotatable.js

+ dataType: "script"
+ }).done((function() {
+ $("#new_legislation_annotation #legislation_annotation_quote").val(this.annotation.quote);
+ $("#new_legislation_annotation #legislation_annotation_ranges").val(JSON.stringify(this.annotation.ranges));


Line 104 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T20:58:13Z

app/assets/javascripts/legislation_annotatable.js

+ event.preventDefault();
+ event.stopPropagation();
+ if (App.LegislationAnnotatable.isMobile()) {
+ annotation_url = $(event.target).closest(".legislation-annotatable").data("legislation-annotatable-base-url");


Line 55 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T20:58:13Z

app/assets/javascripts/imageable.js

+ App.Imageable.clearPreview(data);
+ $("#new_image_link").removeClass("hide");
+ $(data.wrapper).find(".attachment-actions").addClass("small-12").removeClass("small-6 float-right");
+ $(data.wrapper).find(".attachment-actions .action-remove").addClass("small-3").removeClass("small-12");


Line 151 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T20:58:13Z

app/assets/javascripts/imageable.js

+ },
+ setPreview: function(data) {
+ var image_preview;
+ image_preview = "<div class='small-12 column text-center image-preview'><figure><img src='" + data.result.attachment_url + "' class='cached-image'></figure></div>";


Line 126 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T20:58:14Z

app/assets/javascripts/gettext.js

+ "Save": "Guardar",
+ "Edit": "Editar",
+ "Delete": "Borrar",
+ "Unregistered": "<p>Necesitas <a href='/users/sign_in'>iniciar sesión</a> o <a href='/users/sign_up'>registrarte</a> para continuar.</p>"


Line 14 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T20:58:14Z

app/assets/javascripts/documentable.js

+ App.Documentable.clearProgressBar(data);
+ App.Documentable.unlockUploads();
+ $(data.wrapper).find(".attachment-actions").addClass("small-12").removeClass("small-6 float-right");
+ $(data.wrapper).find(".attachment-actions .action-remove").addClass("small-3").removeClass("small-12");


Line 147 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T20:58:15Z

app/assets/javascripts/documentable.js

+ App.Documentable.clearInputErrors(data);
+ $(data.addAttachmentLabel).hide();
+ $(data.wrapper).find(".attachment-actions").removeClass("small-12").addClass("small-6 float-right");
+ $(data.wrapper).find(".attachment-actions .action-remove").removeClass("small-3").addClass("small-12");


Line 60 exceeds the maximum line length of 110 max-len

app/assets/javascripts/documentable.js

houndci-bot · 2019-07-02T20:58:15Z

app/assets/javascripts/comments.js

+ },
+ add_reply: function(parent_id, response_html) {
+ if ($("#" + parent_id + " .comment-children").length === 0) {
+ $("#" + parent_id).append("<li><ul id='" + parent_id + "_children' class='no-bullet comment-children'></ul></li>");


Line 11 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T22:30:34Z

app/assets/javascripts/valuation_budget_investment_form.js

+ }
+ },
+ showFeasibilityFieldsOnChange: function() {
+ $("#valuation_budget_investment_edit_form input[type=radio][name='budget_investment[feasibility]']").change(function() {


Line 26 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T22:30:35Z

app/assets/javascripts/valuation_budget_investment_form.js

+ },
+ showFeasibilityFields: function() {
+ var feasibility;
+ feasibility = $("#valuation_budget_investment_edit_form input[type=radio][name='budget_investment[feasibility]']:checked").val();


Line 18 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T22:30:35Z

app/assets/javascripts/registration_form.js

+ showUsernameMessage = function(response) {
+ var klass;
+ klass = response.available ? "no-error" : "error";
+ usernameInput.after($("<small class=\"" + klass + "\" style=\"margin-top: -16px;\">" + response.message + "</small>"));


Line 13 exceeds the maximum line length of 110 max-len

app/assets/javascripts/map.js

houndci-bot · 2019-07-02T22:30:35Z

app/assets/javascripts/map.js

+ });
+ },
+ initializeMap: function(element) {
+ var addMarkerInvestments, clearFormfields, createMarker, editable, getPopupContent, latitudeInputSelector, longitudeInputSelector, map, mapAttribution, mapCenterLatLng, mapCenterLatitude, mapCenterLongitude, mapTilesProvider, marker, markerIcon, markerLatitude, markerLongitude, moveOrPlaceMarker, openMarkerPopup, removeMarker, removeMarkerSelector, updateFormfields, zoom, zoomInputSelector;


Line 15 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T22:30:37Z

app/assets/javascripts/legislation_annotatable.js

+ dataType: "script"
+ }).done((function() {
+ $("#new_legislation_annotation #legislation_annotation_quote").val(this.annotation.quote);
+ $("#new_legislation_annotation #legislation_annotation_ranges").val(JSON.stringify(this.annotation.ranges));


Line 103 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T22:30:37Z

app/assets/javascripts/legislation_annotatable.js

+ event.preventDefault();
+ event.stopPropagation();
+ if (App.LegislationAnnotatable.isMobile()) {
+ annotation_url = $(event.target).closest(".legislation-annotatable").data("legislation-annotatable-base-url");


Line 54 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T22:30:37Z

app/assets/javascripts/imageable.js

+ App.Imageable.clearPreview(data);
+ $("#new_image_link").removeClass("hide");
+ $(data.wrapper).find(".attachment-actions").addClass("small-12").removeClass("small-6 float-right");
+ $(data.wrapper).find(".attachment-actions .action-remove").addClass("small-3").removeClass("small-12");


Line 150 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T22:30:37Z

app/assets/javascripts/imageable.js

+ },
+ setPreview: function(data) {
+ var image_preview;
+ image_preview = "<div class='small-12 column text-center image-preview'><figure><img src='" + data.result.attachment_url + "' class='cached-image'></figure></div>";


Line 125 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-02T22:30:38Z

app/assets/javascripts/imageable.js

+ App.Imageable.clearInputErrors(data);
+ $(data.addAttachmentLabel).hide();
+ $(data.wrapper).find(".attachment-actions").removeClass("small-12").addClass("small-6 float-right");
+ $(data.wrapper).find(".attachment-actions .action-remove").removeClass("small-3").addClass("small-12");


Line 60 exceeds the maximum line length of 110 max-len

houndci-bot

Some files could not be reviewed due to errors:

.eslintrc:

.eslintrc: Configuration for rule "eqeqeq" is invalid: Value {"":"ignore"} should NOT have additional properties. Value ["always",{"":"ignore"}] should NOT have more than 1 items. Value ["always",{"":"ignore"}] should match some schema in anyOf.

Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)

houndci-bot

Some files could not be reviewed due to errors:

.eslintrc:

.eslintrc: Configuration for rule "eqeqeq" is invalid: Value {"":"ignore"} should NOT have additional properties. Value ["always",{"":"ignore"}] should NOT have more than 1 items. Value ["always",{"":"ignore"}] should match some schema in anyOf.

Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)

houndci-bot

Some files could not be reviewed due to errors:

.eslintrc:

.eslintrc: Configuration for rule "eqeqeq" is invalid: Value {"":"ignore"} should NOT have additional properties. Value ["always",{"":"ignore"}] should NOT have more than 1 items. Value ["always",{"":"ignore"}] should match some schema in anyOf.

Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)

houndci-bot

Some files could not be reviewed due to errors:

.eslintrc:

.eslintrc: Configuration for rule "eqeqeq" is invalid: Value {"":"ignore"} should NOT have additional properties. Value ["always",{"":"ignore"}] should NOT have more than 1 items. Value ["always",{"":"ignore"}] should match some schema in anyOf.

Error: .eslintrc:
at validateRuleOptions (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:119:19)
at Object.keys.forEach.id (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:162:9)
at Array.forEach ()
at validateRules (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:161:30)
at Object.validate (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-validator.js:239:5)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:516:19)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
at Config.getConfigVector (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:286:21)

houndci-bot · 2019-07-03T00:24:54Z

app/assets/javascripts/documentable.js

+ App.Documentable.clearProgressBar(data);
+ App.Documentable.unlockUploads();
+ $(data.wrapper).find(".attachment-actions").addClass("small-12").removeClass("small-6 float-right");
+ $(data.wrapper).find(".attachment-actions .action-remove").addClass("small-3").removeClass("small-12");


Line 146 exceeds the maximum line length of 110 max-len

houndci-bot · 2019-07-03T00:24:54Z

app/assets/javascripts/documentable.js

+ App.Documentable.clearInputErrors(data);
+ $(data.addAttachmentLabel).hide();
+ $(data.wrapper).find(".attachment-actions").removeClass("small-12").addClass("small-6 float-right");
+ $(data.wrapper).find(".attachment-actions .action-remove").removeClass("small-3").addClass("small-12");


Line 59 exceeds the maximum line length of 110 max-len

app/assets/javascripts/documentable.js

houndci-bot · 2019-07-03T00:24:54Z

app/assets/javascripts/comments.js

+ },
+ add_reply: function(parent_id, response_html) {
+ if ($("#" + parent_id + " .comment-children").length === 0) {
+ $("#" + parent_id).append("<li><ul id='" + parent_id + "_children' class='no-bullet comment-children'></ul></li>");


Line 10 exceeds the maximum line length of 110 max-len

app/assets/javascripts/globalize.js

Compiled using `coffee -c` with CoffeeScript 1.12.6.

These statements were automatically added by CoffeeScript. I'm only removing the obvious cases; there might be more cases where the `return` statement isn't necessary.

For now we're only adding rules related to spacing and double quotes, following the same rules we use in Ruby, which are the same rules CoffeeScript followed when compiling these files. We're also using the recommended ESLint rules, which will warn us about many JavaScript common pitfalls, the `strict` rule which enforces using strict mode, and the `no-console` rule, which will prevent us from shipping code meant for debugging. Although it's arguably more common to use the JSON format to define these rules, I've chosen YAML because it's the format we use in all our linters.

We originally wrote `undefined` in CoffeeScript. CoffeeScript compiled it to `void 0` when generating the JavaScript files. However, the reason to do so was the `undefined` variable was mutable before ECMAScript 5. Using `undefined` is more intuitive, and nowadays there's no reason to use `void 0`.

While I personally prefer the "never" option for this rule, we haven't discussed which guideline to follow, so for now I'm applying the rule CoffeeScript used when generating these files.

I'm using the same criteria we use in Ruby: 110 characters, and the severity set as a warning, since it's a rule we break sometimes.

Using `==` and `!=` sometimes causes unexpected behaviour in JavaScript, and it's easy for Ruby developers to use them incorrectly.

The rule is not the most important one, but the name is awesome!

Using the same variable name makes the code more difficult to read. We're also enabling the `no-param-reassing` rule since we accidentally reassigned params in commit 824dd26, and this rule will prevent us from doing so in the future.

It's very easy for Ruby developers to omit the `return` statement in an array callback, such as the ones in `map` or `filter`. Doing so will make those funcions have the same effect as `forEach`, which is usually not the intended behaviour.

We were using the dot notation in most places, but not everywhere.

Using `Array(0, 1, 2)` will *not* create an Array with the elements [0, 1, 2]. This is a mistake I've seen in the past, and the JavaScript community recommends adding this rule.

Migrate CoffeeScript to JavaScript

houndci-bot reviewed Jul 2, 2019

View reviewed changes

app/assets/javascripts/answers.js Outdated Show resolved Hide resolved

app/assets/javascripts/answers.js Outdated Show resolved Hide resolved

app/assets/javascripts/answers.js Show resolved Hide resolved

houndci-bot reviewed Jul 2, 2019

View reviewed changes

javierm self-assigned this Jul 2, 2019

javierm force-pushed the simplify_coffeescript branch from 5ae1e47 to 1fcb1db Compare July 2, 2019 20:55

javierm force-pushed the migrate_coffeescript branch from ba8311e to 793b80e Compare July 2, 2019 20:57

houndci-bot reviewed Jul 2, 2019

View reviewed changes

javierm force-pushed the simplify_coffeescript branch from 1fcb1db to c0e1738 Compare July 2, 2019 21:07

javierm force-pushed the migrate_coffeescript branch from 793b80e to e88e449 Compare July 2, 2019 21:12

javierm force-pushed the simplify_coffeescript branch 2 times, most recently from 5f49387 to e240e98 Compare July 2, 2019 22:29

javierm force-pushed the migrate_coffeescript branch from e88e449 to 245e7d9 Compare July 2, 2019 22:30

houndci-bot reviewed Jul 2, 2019

View reviewed changes

javierm force-pushed the simplify_coffeescript branch from e240e98 to febe71d Compare July 3, 2019 00:17

javierm force-pushed the migrate_coffeescript branch from 245e7d9 to 72c3706 Compare July 3, 2019 00:17

houndci-bot reviewed Jul 3, 2019

View reviewed changes

javierm force-pushed the migrate_coffeescript branch from 72c3706 to ba409c1 Compare July 3, 2019 00:24

houndci-bot reviewed Jul 3, 2019

View reviewed changes

javierm force-pushed the simplify_coffeescript branch from febe71d to efe1160 Compare July 3, 2019 00:29

javierm force-pushed the migrate_coffeescript branch from ba409c1 to eef7b84 Compare July 3, 2019 00:33

javierm force-pushed the simplify_coffeescript branch from efe1160 to 5392646 Compare July 3, 2019 02:08

javierm force-pushed the migrate_coffeescript branch 4 times, most recently from f2f8e7e to 692afcb Compare July 3, 2019 19:40

javierm force-pushed the simplify_coffeescript branch from 5392646 to 798e90b Compare July 7, 2019 21:18

javierm force-pushed the migrate_coffeescript branch from 692afcb to 461eceb Compare July 7, 2019 21:20

javierm force-pushed the simplify_coffeescript branch from 798e90b to de7f0d5 Compare July 7, 2019 21:35

javierm added this to Testing in Roadmap Sep 10, 2019

javierm moved this from Testing to Doing in Roadmap Sep 10, 2019

javierm moved this from Doing to Testing in Roadmap Sep 10, 2019

javierm force-pushed the simplify_coffeescript branch from c3174a8 to f8ad278 Compare September 10, 2019 23:46

javierm force-pushed the migrate_coffeescript branch from 124911c to 412fc10 Compare September 10, 2019 23:46

houndci-bot reviewed Sep 10, 2019

View reviewed changes

javierm force-pushed the migrate_coffeescript branch from 412fc10 to ab27bfd Compare September 10, 2019 23:50

javierm force-pushed the simplify_coffeescript branch from f8ad278 to eb277f0 Compare September 11, 2019 00:09

javierm moved this from Testing to Reviewing in Roadmap Sep 11, 2019

javierm added the Refactoring label Sep 11, 2019

javierm force-pushed the simplify_coffeescript branch from eb277f0 to d8be18d Compare September 11, 2019 01:14

javierm added 12 commits September 11, 2019 14:03

Convert CofeeScript to JavaScript

d93a029

Compiled using `coffee -c` with CoffeeScript 1.12.6.

Remove unnecessary return statements

ec5af1f

These statements were automatically added by CoffeeScript. I'm only removing the obvious cases; there might be more cases where the `return` statement isn't necessary.

Add JavaScript rule for semi colons

9185c0b

While I personally prefer the "never" option for this rule, we haven't discussed which guideline to follow, so for now I'm applying the rule CoffeeScript used when generating these files.

Add JavaScript rule for maximum line length

392095a

I'm using the same criteria we use in Ruby: 110 characters, and the severity set as a warning, since it's a rule we break sometimes.

Add JavaScript rule for comparisons

d9bb553

Using `==` and `!=` sometimes causes unexpected behaviour in JavaScript, and it's easy for Ruby developers to use them incorrectly.

Enable Yoda JavaScript rule

efc32bc

The rule is not the most important one, but the name is awesome!

Apply JavaScript rules to prevent shadowing

044da18

Using the same variable name makes the code more difficult to read. We're also enabling the `no-param-reassing` rule since we accidentally reassigned params in commit 824dd26, and this rule will prevent us from doing so in the future.

Apply JavaScript rule to use the dot notation

af6a494

We were using the dot notation in most places, but not everywhere.

Add JavaScript rule to disallow array constructors

8231096

Using `Array(0, 1, 2)` will *not* create an Array with the elements [0, 1, 2]. This is a mistake I've seen in the past, and the JavaScript community recommends adding this rule.

javierm changed the base branch from simplify_coffeescript to master September 11, 2019 12:03

javierm force-pushed the migrate_coffeescript branch from ab27bfd to 8231096 Compare September 11, 2019 12:03

javierm merged commit f362939 into master Sep 11, 2019

Roadmap automation moved this from Reviewing to Release 1.1.0 Sep 11, 2019

javierm deleted the migrate_coffeescript branch September 11, 2019 13:30

javierm mentioned this pull request Sep 13, 2019

Snake case names on JS coding #1918

Closed

smarques pushed a commit to venetochevogliamo/consul that referenced this pull request Apr 29, 2020

Merge pull request consuldemocracy#3653 from consul/migrate_coffeescript

15bca82

Migrate CoffeeScript to JavaScript

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate CoffeeScript to JavaScript #3653

Migrate CoffeeScript to JavaScript #3653

javierm commented Jul 2, 2019 •

edited

Loading

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot Jul 2, 2019

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot left a comment

houndci-bot Jul 3, 2019

houndci-bot Jul 3, 2019

houndci-bot Jul 3, 2019

Migrate CoffeeScript to JavaScript #3653

Migrate CoffeeScript to JavaScript #3653

Conversation

javierm commented Jul 2, 2019 • edited Loading

References

Background

Objectives

Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javierm commented Jul 2, 2019 •

edited

Loading