Fix order in annotation comments with same score #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting the comments lazily in a different method, we can share its code with the parent class.
Using arrays made it difficult to order by more than one field (like the `most_voted` scope does), and so we were ordering by `confidence_score` and ignoring the `created_at` column. Using an AR relation makes it easy to reuse the existing `most_voted` scope. This change has one side effect: now comments with equal votes are ordered in descending order instead of having no specific order. That means flaky specs which failed sometimes because they assumed comments were ordered by date are now always green. I've also re-added the `oldest` scope removed in 792b15b thinking it was removed because using it with arrays was too hard.
microweb10
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Notes
The specs failed because comments in annotations are ordered by score. However, when several comments have the same score, no other order is defined. This meant specs assuming the last comment displayed was the last comment created failed sometimes.
Using
ActiveRecordrelations instead of arrays makes it easy to reuse scopes used everywhere else in the code, and so comments with the same score are now ordered by date.